feat(vmm): add VM removing state for reliable lifecycle cleanup #497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a "removing" intermediate state so that VM deletion is non-blocking and crash-recoverable: - remove_vm() marks the VM as removing, writes a .removing marker file, and spawns a background coroutine that stops the supervisor process, polls until it exits, removes it from supervisor, deletes the workdir, and finally frees the CID. - On startup (reload_vms) and on RPC reload (reload_vms_sync), VMs with a .removing marker are loaded into memory (visible in UI) and cleanup is resumed via spawn_finish_remove. - spawn_finish_remove checks the in-memory removing flag to avoid duplicate cleanup tasks. - start_vm and try_restart_exited_vms skip VMs in removing state. - UI shows "removing" status badge (amber) for VMs being cleaned up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
remove_vm()marks the VM as removing, persists a.removingmarker file, and spawns a background cleanup coroutine.removingmarker are loaded (visible in UI) and cleanup resumes automaticallyspawn_finish_removededuplicates cleanup tasks via in-memoryremovingflagstart_vmand auto-restart skip VMs in removing stateTest plan